Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS force destroy script, include lingering volumes #1681

Merged
merged 2 commits into from Mar 28, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Mar 15, 2023

Reference Issues or PRs

As part of the work to fix the integration tests, we need to make sure that all the cloud resources are always destroyed. AWS has consistently been the trickiest cloud provider in this regard. This is because individual resources need to be manually deleted if anything with nebari destroy goes wrong.

I am continuing the work I started a few weeks ago and cleaning up this script, most notably ensuring that any lingering volumes are also destroyed.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): clean up script

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added needs: review 👀 This PR is complete and ready for reviewing area: CI/CD 👷🏽‍♀️ type: maintenance 🛠 Day-to-day maintenance tasks area:developer-experience 👩🏻‍💻 status: in review 👀 This PR is currently being reviewed by the team labels Mar 15, 2023
@iameskild iameskild requested a review from costrouc March 15, 2023 19:02
@costrouc costrouc merged commit b887d44 into develop Mar 28, 2023
7 of 25 checks passed
@costrouc costrouc deleted the aws_destroy_script_update branch March 28, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD 👷🏽‍♀️ area:developer-experience 👩🏻‍💻 needs: review 👀 This PR is complete and ready for reviewing status: in review 👀 This PR is currently being reviewed by the team type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants