Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions CI needs id-token write permissions #1682

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

costrouc
Copy link
Member

Related to the need for OIDC support when deploying nebari see issue

Reference Issues or PRs

What does this implement/fix?

#1671

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

This adds the following lines to the render for github

    permissions:
      id-token: write
      contents: read

To the github actions pipeline. From a security perspective there are no risks I can see of adding id-token to the pipeline.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! While I was looking at this, it got me wondering if we even need to include references to REPOSITORY_ACCESS_TOKEN? We don't necessarily need to remove it in this PR, but perhaps something we should look into later.

@costrouc
Copy link
Member Author

Yeah I agree! I think we need to revisit how we set the yaml for github actions and gitlab ci when we work on an extension mechanism.

@costrouc costrouc merged commit 449d383 into develop Mar 16, 2023
@costrouc costrouc deleted the feat-token-id-actions branch March 16, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants