Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent user Experience with y/N. #1747

Merged

Conversation

heyayush09
Copy link
Contributor

It now requires user to press the Enter key after entering y/N as a choice.

Reference Issues or PRs

#1742

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • [x ] Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

It now requires user to press the Enter key after entering y/N as a choice.
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @AM-O7! Good catch on the auto_enter attribute

@heyayush09
Copy link
Contributor Author

@viniciusdc Thank you

@iameskild
Copy link
Member

Thanks for the contribution @AM-O7!!

@iameskild iameskild merged commit b910497 into nebari-dev:develop May 1, 2023
8 checks passed
@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

4 participants