Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s 1.25 + More Improvements #1856

Merged
merged 15 commits into from Aug 23, 2023
Merged

K8s 1.25 + More Improvements #1856

merged 15 commits into from Aug 23, 2023

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Jul 5, 2023

  • K8s 1.25,
  • JHub 3.1,
  • Updated Nvidia drivers,
  • Remove CDS Dashboards
  • Enable Cost Allocation by default on GKE
  • allow custom tags and labels to be added to GCP deploments

Reference Issues or PRs

Resolves #1849

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis
Copy link
Member Author

This shouldn't be meged until we add some docs about CDS Dashboards deprecation.

@Adam-D-Lewis Adam-D-Lewis changed the title K8s 1.25, JHub 3.1, Updated Nvidia drivers, Remove CDS Dashboards K8s 1.25 + More Improvements Jul 6, 2023
@pavithraes pavithraes added type: maintenance 🛠 Day-to-day maintenance tasks status: in progress 🏗 This task is currently being worked on area: JupyterLab area: k8s ⎈ status: in review 👀 This PR is currently being reviewed by the team and removed status: in progress 🏗 This task is currently being worked on labels Jul 11, 2023
@iameskild
Copy link
Member

@costrouc is it safe to assume that this will be merged before the large extension-mechanism PR?

@iameskild iameskild added this to the Release 2023.8.1 milestone Aug 14, 2023
@iameskild
Copy link
Member

@Adam-D-Lewis if it's alright with you, I'm going to resolve the conflicts in this PR and get it merged.

@Adam-D-Lewis
Copy link
Member Author

For sure, thanks Eskild!

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on an Azure deployment and this works if used with these images. The kubernetes test in CI doesn't use those images and so this fails.

Thanks @Adam-D-Lewis 🎉

@iameskild iameskild merged commit 9e92a30 into develop Aug 23, 2023
26 checks passed
@iameskild iameskild deleted the jh3 branch August 23, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: JupyterLab area: k8s ⎈ status: in review 👀 This PR is currently being reviewed by the team type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Support K8s 1.25
3 participants