New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s 1.25 + More Improvements #1856
Conversation
This shouldn't be meged until we add some docs about CDS Dashboards deprecation. |
@costrouc is it safe to assume that this will be merged before the large extension-mechanism PR? |
@Adam-D-Lewis if it's alright with you, I'm going to resolve the conflicts in this PR and get it merged. |
For sure, thanks Eskild! |
src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/jupyterhub/main.tf
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on an Azure deployment and this works if used with these images. The kubernetes test in CI doesn't use those images and so this fails.
Thanks @Adam-D-Lewis 🎉
Reference Issues or PRs
Resolves #1849
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?