Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lifecycle ignore to eks node group #1905

Merged
merged 3 commits into from Aug 23, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Adding lifecycle ignore to prevent current asg size from being overwritten on deploy

Reference Issues or PRs

Fixes #1901

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pavithraes pavithraes added the status: in review 👀 This PR is currently being reviewed by the team label Aug 14, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks @sblair-metrostar!

@sblair-metrostar
Copy link
Contributor Author

@iameskild Made a small change to remove the create_before_destroy setting after more testing. The Nebari node groups are statically named so will conflict with this setting on. Moving to the EKS module will resolve the issue properly, best to wait till then to keep things easy. The ignore part is still fine.

@iameskild iameskild merged commit 1a0e9d2 into nebari-dev:develop Aug 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: k8s ⎈ provider: AWS status: in review 👀 This PR is currently being reviewed by the team
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Nebari deploy in AWS overwrites the node group desired_size value
3 participants