Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests, add cleanup step for Digital Ocean integration test #1910

Merged
merged 8 commits into from Aug 21, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Aug 15, 2023

Reference Issues or PRs

This is related to #1862

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pavithraes pavithraes added the status: in review 👀 This PR is currently being reviewed by the team label Aug 15, 2023
@iameskild
Copy link
Member Author

@costrouc could you take a look at this when you get a chance?

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a look, it looks excellent to me! Thanks for all the great work @iameskild 🎉

@iameskild iameskild merged commit 735a0ca into develop Aug 21, 2023
25 of 26 checks passed
@iameskild iameskild deleted the 20230814 branch August 21, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing ✅ Testing provider: Digital Ocean status: in review 👀 This PR is currently being reviewed by the team
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

3 participants