Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup step for AWS integration test, ensure diable_prompt is passed through #1921

Merged
merged 22 commits into from Aug 22, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Aug 18, 2023

Related to #1872

Besides the large number of AWS related clean-up functions, I included a few fixes as they came up

  • ensure disable_prompt and disable_checks are passed through
  • add deprecation warnings for dns-provider, dns-auto-provision in the CLI help menu
  • ensure the skip-terraform-state-provision flag works

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): tests

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild requested review from aktech and costrouc and removed request for aktech August 18, 2023 15:02
@iameskild iameskild requested a review from aktech August 21, 2023 16:27
Base automatically changed from 20230814 to develop August 21, 2023 21:55
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable_prompt: bool = False yeah adding this looks inevitable. I don't have any issues with this PR.

@iameskild iameskild merged commit 50487a3 into develop Aug 22, 2023
26 checks passed
@iameskild iameskild deleted the 20230816 branch August 22, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants