Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: fix return class type in hookimpl #1975

Merged
merged 4 commits into from Sep 4, 2023
Merged

TYP: fix return class type in hookimpl #1975

merged 4 commits into from Sep 4, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 4, 2023 •
edited

Reference Issues or PRs

xref #1800

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Solution reference: https://docs.python.org/3/library/typing.html#the-type-of-class-objects

@fangchenli fangchenli marked this pull request as ready for review September 4, 2023 17:44
@iameskild iameskild added type: maintenance 🛠 Day-to-day maintenance tasks type:extension Nebari Extension labels Sep 4, 2023
iameskild
iameskild reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any dependency on #1974?

@fangchenli
Copy link
Member Author

Does this have any dependency on #1974?

No. This is a separate error.

iameskild
iameskild approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@iameskild iameskild merged commit 8b71702 into nebari-dev:develop Sep 4, 2023
9 checks passed
@fangchenli fangchenli deleted the fix-class-type branch September 5, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
type:extension Nebari Extension type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fangchenli @iameskild