Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package dependencies #1986

Merged
merged 42 commits into from Sep 14, 2023
Merged

Update package dependencies #1986

merged 42 commits into from Sep 14, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Sep 5, 2023 •
edited

Reference Issues or PRs

Closes #1985
I also pinned setuptools as a dev dependency to get around #1984

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

iameskild and others added 25 commits August 22, 2023 20:16
@iameskild
Add region to init cmd, update tests_integrations
8fbde6f
@iameskild
Clean up
cc25b9a
@iameskild
Shuffle functions
cadc0d5
@iameskild
Ensure region is handled carefully, set default values
ba4791e
@iameskild
Clean up kubernetes_version
96b46b4
@iameskild
Clean up
a4d17e2
@iameskild
Make region eager
cc88f8a
@iameskild
Merge branch 'develop' into 20230822
272b9f6
@iameskild
Merge branch 'develop' into 20230822
649bb77
@iameskild
Remove on_cloud for --cloud instead
4418a5b
@iameskild
Make project required
2193664
@iameskild
Update tests_integration README
ed95606
@iameskild
Update cli_init tests to include region
8e54303
@iameskild
Merge branch 'develop' into 20230822
b9a1c5a
@iameskild
Add more robust clean up for integration tests
561dedf
@iameskild
Add azure-mgmt-resource as a dependency
bcd0717
@iameskild
Handle test failure gracefully
e26d371
@iameskild
Minor updates
38d9d0b
@iameskild
Merge branch 'develop' into 20230822
b75d1c6
@iameskild
Merge branch 'develop' into 20230822
0bb61a6
@iameskild
Merge develop
08f5e51
@iameskild
Add azure storge_account_postfix to initialize
b1ab4c1
@iameskild
Remove empty nb
7a60401
@iameskild
Update azure cli validate test
0f5692a
@iameskild
Update package dependencies
1c932b6
@iameskild iameskild added the area: dependencies 📦 All things dependencies label Sep 5, 2023
@iameskild
Copy link
Member Author

Given that we are also looking at upgrading Pydantic, this is blocked by #1928.

@iameskild iameskild added the status: blocked ⛔️ This item is on hold due to another task label Sep 5, 2023
@iameskild iameskild linked an issue Sep 5, 2023 that may be closed by this pull request
DEPS: Keycloak python client uses deprecated urllib3 module #1985
Closed
@fangchenli
Copy link
Member

Given that we are also looking at upgrading Pydantic, this is blocked by #1928.

We don't have to wait for #1928. For Pydantic, we could bump it to the last v1 version 1.10.12 for now and migrate to v2 after the next release.

@iameskild iameskild removed the status: blocked ⛔️ This item is on hold due to another task label Sep 8, 2023
Base automatically changed from 20230822 to develop September 11, 2023 15:25
@iameskild iameskild added this to the Release 2023.9.1 milestone Sep 12, 2023
@iameskild
Copy link
Member Author

Thanks for reviewing @fangchenli! Unfortunately merging is still blocked. @pavithraes do you mind reviewing when you get a chance? Thank you both :)

@iameskild iameskild self-assigned this Sep 13, 2023
sblair-metrostar
sblair-metrostar approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@sblair-metrostar sblair-metrostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pavithraes
Copy link
Member

Can merge after CI passes :)

aktech
aktech reviewed Sep 14, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
@iameskild iameskild merged commit 55a5323 into develop Sep 14, 2023
26 checks passed
@iameskild iameskild deleted the deps/updates branch September 14, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech approved these changes

@fangchenli fangchenli fangchenli approved these changes

@pavithraes pavithraes pavithraes approved these changes

@sblair-metrostar sblair-metrostar sblair-metrostar approved these changes

Assignees

@iameskild iameskild

Labels
area: dependencies 📦 All things dependencies
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
2023.10.1
Development

Successfully merging this pull request may close these issues.

DEPS: Keycloak python client uses deprecated urllib3 module
5 participants
@iameskild @fangchenli @pavithraes @aktech @sblair-metrostar