Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom auth from config schema #1994

Merged
merged 3 commits into from Sep 11, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Fixes #1934

Removes the custom auth provider option from the config schema. Includes unit tests to cover the upgrade path that was intended to handle the removal of this previously.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sblair-metrostar!!

@iameskild iameskild merged commit 1e4ba1c into nebari-dev:develop Sep 11, 2023
9 checks passed
@iameskild iameskild added this to the Release 2023.9.1 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Nebari init fails with --auth-provider custom
2 participants