Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gcp_cleanup, minor changes #2010

Merged
merged 34 commits into from Sep 21, 2023
Merged

Add gcp_cleanup, minor changes #2010

merged 34 commits into from Sep 21, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Sep 14, 2023 •
edited

Reference Issues or PRs

closes #1989

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild mentioned this pull request Sep 15, 2023
Merged
10 tasks
@iameskild iameskild marked this pull request as ready for review September 18, 2023 16:14
@iameskild
Copy link
Member Author

I've removed the integration workflow due to issues I kept running into. This is likely related to OIDC - see #2018

@iameskild iameskild changed the title Add initial GCP integration test Add gcp_cleanup, minor changes Sep 20, 2023
@iameskild iameskild added this to the Release 2023.9.1 milestone Sep 20, 2023
@pavithraes pavithraes added the status: approved 💪🏾 This PR has been reviewed and approved for merge label Sep 20, 2023
@iameskild iameskild merged commit 6d01b04 into develop Sep 21, 2023
26 checks passed
@iameskild iameskild deleted the it_gcp branch September 21, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangchenli fangchenli fangchenli approved these changes

@pavithraes pavithraes pavithraes approved these changes

Assignees
No one assigned
Labels
area: testing ✅ Testing provider: GCP status: approved 💪🏾 This PR has been reviewed and approved for merge
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
2023.10.1
Development

Successfully merging this pull request may close these issues.

[BUG] - PROJECT_ID env variable is not working for GCP deployment
4 participants
@iameskild @fangchenli @pavithraes @sblair-metrostar