Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upgrade for 2023.10.1 #2080

Merged
merged 3 commits into from Oct 20, 2023
Merged

Update upgrade for 2023.10.1 #2080

merged 3 commits into from Oct 20, 2023

Conversation

kenafoster
Copy link
Contributor

Reference Issues or PRs

#2015

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • [X ] Build related changes
  • Other (please describe):

Testing

  • [X ] Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Minor changes to CLI upgrade command and related tests since version of release is now 2023.10.1

@iameskild iameskild added the type: maintenance 🛠 Day-to-day maintenance tasks label Oct 20, 2023
iameskild
iameskild reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenafoster!

I left one comment, requesting we add another deprecation warning. Otherwise, this looks good to me!

src/_nebari/upgrade.py Show resolved Hide resolved
iameskild
iameskild approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and everything looks good to me!

Thanks @kenafoster!

@iameskild iameskild merged commit 76769e0 into nebari-dev:develop Oct 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenafoster @iameskild