Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable AWS tags support #2096

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Re-enable AWS tags support #2096

merged 6 commits into from
Nov 14, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Oct 29, 2023

Reference Issues or PRs

Closes #2095

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild changed the title Aws tags eae Re-enable AWS tags support Oct 29, 2023
@iameskild iameskild requested a review from aktech November 8, 2023 06:52
@iameskild iameskild added this to the 2023.11.1 milestone Nov 8, 2023
@dcmcand
Copy link
Contributor

dcmcand commented Nov 13, 2023

@iameskild does this actually close #2095? It looks like it is part of #2095, but private subnet/vpc support is still needed.

@iameskild
Copy link
Member Author

iameskild commented Nov 14, 2023

@dcmcand ah yes, there was already support for private/existing VPC and subnets, and I realized that it were just a small bug that was preventing it from working:

https://github.com/nebari-dev/nebari/pull/2096/files#diff-85a0aac851ba9454fb93be1ed93f3907ecbcea446f599a91424183dbce3cec75R447-R448

It should have been singular existing_security_group_id.

@iameskild iameskild merged commit f28436a into develop Nov 14, 2023
27 checks passed
@iameskild iameskild deleted the aws_tags_eae branch November 14, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Support AWS deployment in restrictive environment
3 participants