Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: cleanup typing and typing import in init #2107

Merged
merged 1 commit into from Nov 13, 2023

Conversation

fangchenli
Copy link
Member

Reference Issues or PRs

split #1928

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@fangchenli fangchenli added the type: maintenance 🛠 Day-to-day maintenance tasks label Nov 11, 2023
@fangchenli fangchenli changed the title CLN: fix typing import in init CLN: cleanup typing and typing import in init Nov 12, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli!

@iameskild iameskild merged commit 49b4d17 into nebari-dev:develop Nov 13, 2023
11 checks passed
@fangchenli fangchenli deleted the fix-typing-import-init branch November 13, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants