Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant pydantic class, fix bug #2426

Merged
merged 1 commit into from Apr 29, 2024
Merged

remove redundant pydantic class, fix bug #2426

merged 1 commit into from Apr 29, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Apr 25, 2024 •
edited

Reference Issues or PRs

Fixes #2425 associated with pydantic v1 vs v2 behavior.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally? Deployed GPUs on GCP to test. The fix works.
  • Did you add new tests?

Any other comments?

Adam-D-Lewis
Adam-D-Lewis commented Apr 25, 2024
View reviewed changes
src/_nebari/stages/infrastructure/__init__.py
@@ -57,19 +57,14 @@ class DigitalOceanInputVars(schema.Base):
kubeconfig_filename: str = get_kubeconfig_filename()


class GCPGuestAccelerators(schema.Base):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice the nearly identical class on line 301 in this file

@Adam-D-Lewis Adam-D-Lewis requested a review from a team April 25, 2024 20:43
@Adam-D-Lewis Adam-D-Lewis added this to the 2024.5.1 milestone Apr 25, 2024
viniciusdc
viniciusdc approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viniciusdc viniciusdc merged commit 3e0f41d into develop Apr 29, 2024
26 checks passed
@viniciusdc viniciusdc deleted the guest_accel_fix branch April 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

@kcpevey kcpevey Awaiting requested review from kcpevey

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
2024.5.1
Development

Successfully merging this pull request may close these issues.

[BUG] - fix guest accelerators on GCP on develop
3 participants
@Adam-D-Lewis @kcpevey @viniciusdc