-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get kubernetes versions for all cloud providers #874
Conversation
Could you add some information in https://docs.qhub.dev/en/stable/source/installation/configuration.html?highlight=kuberentes%20version#providers about how the Kubernetes versions for all providers update frequently and if nothing is explicitly specified And remove this text from the docs in favor of the more general message.
|
Otherwise this PR looks good to me 😄 |
Thanks for taking a look @costrouc, I'll make sure to update the docs and fix these tests. I was hoping to add a Kubernetes check for GCP as well. |
Absolutely. If you feel it would be best to include that work in this PR go for it. Like I mentioned in the meeting long term goal wold be that for QHub we are able to get (for each provider):
By no means something that needs to be done in a single PR. |
I apologize, the scope of this PR grew larger than I intended...
|
Thanks @iameskild this is a great contribution and glad the scope grew! This will make us handle all cloud providers more consistently. And no problem with the linting issues on documentation. It is going to throw a lot of errors for awhile. |
@costrouc This PR is ready for another look whenever you get a chance. The biggest change is that |
Many of the CI workflows are failing because this PR is coming from my fork and thus it doesn't have access to the Secrets. I will reopen this PR and make sure all the tests pass before requesting another review 👍 |
Replaced by #927 |
Closes #854