Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change the functionality of the code but rather makes some suggestions in line with Rust idioms. The biggest change is in
populate_primer_count_hash
wherelet key = if
replaces the double-assignment ofkey
andis_some
is used at the insert step and then the rewrite ofimport_primer_sets
to reduce use ofmut
and prefer a more "functional" style to a more "C-like" approach of initialising and then updating a hashmap.Further down the code
identify_primer_sets
has an if-chain replaced with amatch
based on a clippy suggestion. I'm less sure that this is an improvement - it usesmatch
rather than an if-chain, which is more ideomatic for Rust, but the use ofOrdering::Equal
etc might make things less readable to some users.