-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/masterset #20
Merged
gorj-tessella
merged 16 commits into
feature/ekappotis/gem-plate-map
from
feature/masterset
Sep 27, 2017
Merged
Feature/masterset #20
gorj-tessella
merged 16 commits into
feature/ekappotis/gem-plate-map
from
feature/masterset
Sep 27, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is only one unit or a default unit specifed, show the unit to the right of the field. Units now render to the right of the field, not on top of it. Also make a number of changes in CSS for simplicity, responsiveness
Creted new file assets.js.erb which handles all asset pipeline calls. This allows us to use replacement calls in index.html and index2.html for testing.
…o feature/numunits
Make maximum use of space.
Also got rid of menu row.
This was referenced Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of feature/numunits - that should be merged first.
This provides a number of fixes and enhancements to better support working with well indices/locations/addresses. All of these are essential for supporting application of mastersets, which is actually done with javascript stored in ebase. A parallel set of changes were made in feature/masterset on the ebase repository.
Among other things, the "menu" in plate-map was removed, since we also had a menu in overlay. Functions have been consolidated there.