fix exception when calling getWarnings #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Young-Flash
reviewed
Jun 13, 2023
| public SQLWarning getWarnings() throws SQLException { | ||
| throw ExceptionBuilder.buildUnsupportedOperationException(); | ||
| public SQLWarning getWarnings() { | ||
| return null; |
There was a problem hiding this comment.
could you explain why always return null here?
There was a problem hiding this comment.
This issue answers the question very well #54.
Clickhouse jdbc client is also written in this way and returns null
There was a problem hiding this comment.
Directly returning null may not be the best approach. It would be better if we could return SQLWarning. I'd like to merge this PR first. How do you think, @wey-gu?
Thank you for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return no sql warnings.
closes #54