-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending NgPath #228
Extending NgPath #228
Conversation
private NgVertex<I> src = new NgVertex<>(); | ||
private Map<String,Object> properties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的默认值给 null 会不会好一点,可以与是否使用了with prop
的区分度做得更大一点,近一步降低开发上使用不当的风险,以及问题排查的成本。你感觉如何?
然后在 dst 与 src 的 javadoc 中新增内容,以达到以下的效果:
开发体验优化上的建议而已,都挺好的,相信这个新特性可以为更多人带来便捷。
cc: @wey-gu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我考虑了使用null,但由于segments中是一定包含node实体的,我无法判断语句中是否使用了with prop。如果通过判断properties中有没有属性来判断也不准确,因为vertex的tag创建时有可能就没有设置属性。segments中一定有node实体,所以默认new一个对象也不用担心什么。javadoc我明天上班补充。另外就是,我非常喜欢ngbatis这个项目,要不是发现了ngbatis,我们还在自研通用业务接口呢😂😂😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的默认值给 null 会不会好一点,可以与
是否使用了with prop
的区分度做得更大一点,近一步降低开发上使用不当的风险,以及问题排查的成本。你感觉如何?
然后在 dst 与 src 的 javadoc 中新增内容,以达到以下的效果:
开发体验优化上的建议而已,都挺好的,相信这个新特性可以为更多人带来便捷。
cc: @wey-gu
这个PR不要马上合并,我需要对segments的准确性再验证一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好~
我考虑了使用null,但由于segments中是一定包含node实体的,我无法判断语句中是否使用了with prop。如果通过判断properties中有没有属性来判断也不准确,因为vertex的tag创建时有可能就没有设置属性。segments中一定有node实体,所以默认new一个对象也不用担心什么。javadoc我明天上班补充。另外就是,我非常喜欢ngbatis这个项目,要不是发现了ngbatis,我们还在自研通用业务接口呢😂😂😂
我个人很喜欢这条回复~ 哈哈哈
另外,不介意的话,可以再补提交一个信息
Lines 18 to 31 in ef14e07
<developers> | |
<developer> | |
<name>CorvusYe</name> | |
<email>CorvusY@foxmail.com</email> | |
</developer> | |
<developer> | |
<name>zhangbin</name> | |
<email>1394078687@qq.com</email> | |
</developer> | |
<developer> | |
<name>soul-gin</name> | |
<email>1533119789@qq.com</email> | |
</developer> | |
</developers> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非常感谢您的认可!
Excellent job and golden collaboration!!! @1244453393 @CorvusYe 🧎 |
改造路径查询,路径对象中带有edge属性和vertex实体+vertex属性,经过测试,无需修改daoBasic任何代码,兼容已有代码
implementation: #225