fix:class 'ResultSetUtil.java' parse datetime type error #240 #241
Conversation
|
I had put this fix PR as hacktoberfest, check https://bit.ly/hack-nebula on how to participate :) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 74 74
Lines 2532 2533 +1
Branches 275 275
======================================
- Misses 2532 2533 +1
☔ View full report in Codecov by Sentry. |
| @@ -126,27 +127,28 @@ public static <T> T getValue(ValueWrapper valueWrapper, Class<T> resultType) { | |||
| } | |||
|
|
|||
| private static Object transformDateTime(DateTimeWrapper dateTime) { | |||
| DateTime localDateTime = dateTime.getLocalDateTime(); | |||
There was a problem hiding this comment.
can we give some description about Why convert the datetime to localDateTime?
If i am using other zone but not utc8, is there any problems with the results?
There was a problem hiding this comment.
can we give some description about Why convert the datetime to localDateTime? If i am using other zone but not utc8, is there any problems with the results?
It seems like this.
There was a problem hiding this comment.
You'd better test it locally.when the zone is GMT+8, this method of converting time will ultimately result in 8 hours less than expected.
There was a problem hiding this comment.
My nebula-storaged has been unable to start recently and lacks a cross time zone testing environment, so it has been unable to verify. T^T
There was a problem hiding this comment.
This looks like the data returned after calling the service is correct, but after conversion, an error occurred
There was a problem hiding this comment.
that's the time zone of the machine where the nebula service is located?
There was a problem hiding this comment.
it‘s deployed on a virtual machine, the time zone is correct.
There was a problem hiding this comment.
I see the point, use LocalDateTime can get the correct time info according to the local zone.
No description provided.