add new method: listEndNodes #272
Conversation
| * @param startId 开始节点的id | ||
| * @return 结束节点列表 | ||
| */ | ||
| default List<?> listEndNodes(Class<?> endType, Class<?> edgeType, I startId) { |
There was a problem hiding this comment.
Would it be more in line with normal thinking if we switched the first parameter and the third parameter? What do you think?
Line 431 is the same.
There was a problem hiding this comment.
Interchanging the first and third arguments is exactly easier to understand. Thank you for these details!
|
@shbone |
…rguments * Update test case
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 75 75
Lines 2566 2574 +8
Branches 278 279 +1
======================================
- Misses 2566 2574 +8 ☔ View full report in Codecov by Sentry. |
| @@ -501,6 +501,12 @@ public void listStartNodes() { | |||
| System.out.println(JSON.toJSONString(personList)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void listEndNodes() { | |||
| List<Person> personList = repository.listEndNodes("易小海", Like.class); | |||
There was a problem hiding this comment.
Shoud we default think that the user know endType of endNodes? @CorvusYe
There was a problem hiding this comment.
Yes，one is that you can specify the type of endNode, another is that you dont't know the type of endNode tha you just know the type of startNode and edge.
NO, I have no suggestion temporarily |
| new Class[]{Serializable.class, Class.class, Class.class}, endVertexName, edgeName, | ||
| startId); |
There was a problem hiding this comment.
The type order here looks like it doesn't match the argument order.
|
🎉! |
add new method: listEndNodes
add new test case about listEndNodes