Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable migration from Nebula locks to Gradle core locks #156

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

OdysseusLives
Copy link
Member

Enable migration from Nebula locks to Gradle core locks with '-PmigrateLocks=true' and coreLockingSupport enabled

@coveralls
Copy link

Coverage Status

Coverage increased (+2.8%) to 88.202% when pulling 0971dc7 on migrate_locks into 6ec1b85 on master.

Copy link
Member

@rpalcolea rpalcolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like it.

Just one question, not a show stopper

./gradlew -DmigrateLocks=true

Is there an advantage of using a flag instead of creating a gradle task to migrate? I guess creating the task would require more work to apply the plugin? thoughts?

@OdysseusLives
Copy link
Member Author

Yeah. I thought about making another task. On one hand, tasks are awesome! On the other, this is something you're really likely to only run once, so it's less important to be a task perhaps. Doing it this way also seemed simpler from the task setup viewpoint, though that can be changed if we want.

@rpalcolea
Copy link
Member

This is great! Can’t wait to see it in action

@OdysseusLives OdysseusLives merged commit beac820 into master Mar 13, 2019
@OdysseusLives OdysseusLives deleted the migrate_locks branch March 13, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants