Migrate locks #157
Merged
Migrate locks #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalcolea
reviewed
Mar 15, 2019
| @@ -0,0 +1,76 @@ | |||
| /** | |||
| * | |||
| * Copyright 2018 Netflix, Inc. | |||
There was a problem hiding this comment.
not a big deal but this might have to be 2019 :)
There was a problem hiding this comment.
Haha, yes! I'll adjust that. Thanks!
rpalcolea
reviewed
Mar 15, 2019
| List<String> findConfigurationsToLock() { | ||
|
|
||
| def configurationsToLock = new ArrayList<>() | ||
| def baseConfigurations = [ |
rpalcolea
reviewed
Mar 15, 2019
| import org.gradle.api.tasks.OutputDirectory | ||
| import org.gradle.api.tasks.TaskAction | ||
|
|
||
| class MigrateToCoreLocksTask extends AbstractLockTask { |
There was a problem hiding this comment.
This is awesome! thanks for adding a task!
There was a problem hiding this comment.
I'm glad for it, too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to core lock format via the new
migrateToCoreLockstaskThis will lock standard configurations, as well as those from facets such as those created via the
nebula-project-pluginor others whose family of configuration names contain one withCompileOnlyin the configuration name (smokeTestCompileOnly, for example)You can also lock all configurations via the property
lockAllConfigurationsif that's what is wanted