Deprecated dependency configuration rule #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up: added support for replacing in project dependencies too |
src/main/resources/META-INF/lint-rules/all-dependency.properties
Outdated
Show resolved
Hide resolved
| def result = runTasksSuccessfully('fixGradleLint', '--warning-mode=none') | ||
|
|
||
| then: | ||
| def buildGradle = new File(projectDir, 'sub1/build.gradle') |
There was a problem hiding this comment.
I think it would be clearer for this variable name to indicate it is the sub1's build file
Co-Authored-By: rpalcolea <rperezalcolea@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work for #203
Several dependencies configurations have been deprecated but gradle-lint-plugin makes recommendations to use those.
While it could be possible to modify existing rules to use the non-deprecated configurations, it would break backwards compatibility since this was introduced in gradle 4.7 so it isn't that old.
I propose to introduce this rule that applies for gradle 4.7 which would replace configurations and in the future we can revisit this. Perhaps for Gradle 6 it would make sense to stop supporting Gradle < 4.5