Skip to content
This repository has been archived by the owner on Mar 1, 2021. It is now read-only.

Commit

Permalink
Gradle 2.14 compatibility
Browse files Browse the repository at this point in the history
Relocate dependency to new group to prevent the next release from being resolved by old versions of the publish plugin that had dynamic version constraints published
  • Loading branch information
DanielThomas committed Jun 4, 2016
1 parent 51129ab commit 49d23e8
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 5 deletions.
3 changes: 3 additions & 0 deletions build.gradle
Expand Up @@ -19,6 +19,8 @@ plugins {
id 'nebula.plugin-plugin' version '4.18.0'
}

group 'com.netflix.nebula.core'

description 'Common classes that plugins might need'

contacts {
Expand All @@ -29,6 +31,7 @@ contacts {
}

dependencies {
compile 'com.google.guava:guava:latest.release'
compile 'org.apache.commons:commons-lang3:latest.release'
compile 'org.apache.httpcomponents:httpclient-cache:latest.release'
}
36 changes: 36 additions & 0 deletions dependencies.lock
@@ -1,5 +1,9 @@
{
"compile": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"org.apache.commons:commons-lang3": {
"locked": "3.4",
"requested": "latest.release"
Expand All @@ -10,6 +14,10 @@
}
},
"compileClasspath": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"org.apache.commons:commons-lang3": {
"locked": "3.4",
"requested": "latest.release"
Expand All @@ -20,6 +28,10 @@
}
},
"compileOnly": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"org.apache.commons:commons-lang3": {
"locked": "3.4",
"requested": "latest.release"
Expand All @@ -30,6 +42,10 @@
}
},
"default": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"org.apache.commons:commons-lang3": {
"locked": "3.4",
"requested": "latest.release"
Expand All @@ -50,6 +66,10 @@
}
},
"runtime": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"org.apache.commons:commons-lang3": {
"locked": "3.4",
"requested": "latest.release"
Expand All @@ -60,6 +80,10 @@
}
},
"testCompile": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"com.netflix.nebula:nebula-test": {
"locked": "4.2.0",
"requested": "4.2.0"
Expand All @@ -74,6 +98,10 @@
}
},
"testCompileClasspath": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"com.netflix.nebula:nebula-test": {
"locked": "4.2.0",
"requested": "4.2.0"
Expand All @@ -88,6 +116,10 @@
}
},
"testCompileOnly": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"com.netflix.nebula:nebula-test": {
"locked": "4.2.0",
"requested": "4.2.0"
Expand All @@ -102,6 +134,10 @@
}
},
"testRuntime": {
"com.google.guava:guava": {
"locked": "19.0",
"requested": "latest.release"
},
"com.netflix.nebula:nebula-test": {
"locked": "4.2.0",
"requested": "4.2.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/groovy/nebula/core/CopySpecHelper.groovy
@@ -1,6 +1,6 @@
package nebula.core

import org.apache.commons.lang.reflect.FieldUtils
import org.apache.commons.lang3.reflect.FieldUtils
import org.gradle.api.Action
import org.gradle.api.internal.file.CopyActionProcessingStreamAction
import org.gradle.api.internal.file.copy.*
Expand All @@ -10,7 +10,6 @@ import org.gradle.internal.reflect.DirectInstantiator
import org.gradle.internal.reflect.Instantiator

class CopySpecHelper {

static visitCopySpec(CopySpecInternal copySpec, Closure closure) {
Instantiator instantiator = new DirectInstantiator()
//FileSystem fileSystem = new GenericFileSystem(new EmptyChmod(), new FallbackStat(), new FallbackSymlink())
Expand Down Expand Up @@ -46,7 +45,7 @@ class CopySpecHelper {
static CopySpecInternal findCopySpec(CopySpecInternal delegateCopySpec, Closure<Boolean> closure) {
def foundCsi = null
visitAllCopySpecs(delegateCopySpec) { CopySpecInternal csi, FileCopyDetailsInternal details ->
if(foundCsi==null && closure.call(csi, details)) {
if (foundCsi == null && closure.call(csi, details)) {
foundCsi = csi
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/groovy/nebula/core/GradleHelper.groovy
Expand Up @@ -14,8 +14,8 @@ import org.gradle.api.internal.artifacts.ivyservice.resolutionstrategy.DefaultRe
import org.gradle.api.internal.project.AbstractProject
import org.gradle.internal.event.BroadcastDispatch
import org.gradle.listener.ClosureBackedMethodInvocationDispatch
import org.gradle.messaging.dispatch.Dispatch
import org.gradle.messaging.dispatch.MethodInvocation
import org.gradle.internal.dispatch.Dispatch
import org.gradle.internal.dispatch.MethodInvocation

/**
* Utility methods to dive into Gradle internals, if needed.
Expand Down

0 comments on commit 49d23e8

Please sign in to comment.