Skip to content

Commit

Permalink
Merge pull request #108 from chali/RefactorStatusAndStatusSchemeReading
Browse files Browse the repository at this point in the history
Publishing verification need Gradle 4.8 now
  • Loading branch information
chali committed Jun 12, 2018
2 parents 33a65e4 + 0717d27 commit 04ec55d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ Eliminates this boilerplate:

### nebula.publish-verification

Plugin features are enabled only for Gradle 4.4 and higher.
Plugin features are enabled only for Gradle 4.8 and higher.
Creates a task which runs before actual publication into repositories. It catches some known bad patters so you can make explicit decision dependency by dependency.

#### Usage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class PublishVerificationPlugin implements Plugin<Project> {
}

private static boolean shouldApplyPlugin() {
GradleVersion minVersion = GradleVersion.version("4.4")
GradleVersion minVersion = GradleVersion.version("4.8")
GradleVersion.current() >= minVersion
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ class PublishVerificationPluginIntegrationSpec extends IntegrationSpec {
noExceptionThrown()
}

def 'plugin should be applied when gradle 4.4 and higher'() {
def 'plugin should be applied when gradle 4.8 and higher'() {
given:
gradleVersion = version

Expand All @@ -612,8 +612,8 @@ class PublishVerificationPluginIntegrationSpec extends IntegrationSpec {

where:
version | taskPresent
"4.3" | false
"4.4" | true
"4.7" | false
"4.8" | true
}

def 'unresolved dependencies should fail fast with clear message'() {
Expand Down

0 comments on commit 04ec55d

Please sign in to comment.