Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error when last tag is not a valid version. The hope is to provide more context when someone intent to release final or candidate but have a typo in a tag. #147

Merged

Conversation

chali
Copy link
Member

@chali chali commented May 22, 2019

Plugin will find latest succesful release tag but because it won't be on current commit it will fail with a message listing actually present on the current commit.

Example: Tags like v1.0.0-rc.01 are not valid because leading zeros in rc count.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 69.62% when pulling 3df9907 on chali:ImproveErrorsWhenTagIsNotValidVersion into 2a327df on nebula-plugins:master.

Copy link
Member

@rpalcolea rpalcolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chali chali merged commit 5e5e9e4 into nebula-plugins:master May 23, 2019
Copy link
Member

@OdysseusLives OdysseusLives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants