Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devSnapshot - remove attaching of STAGE_FLOAT #162

Merged
merged 1 commit into from Sep 13, 2019
Merged

Conversation

rpalcolea
Copy link
Member

This is a proposal for fixing the case where generating candidate results in 1.0.0-rc.1 and next devSnapshot will be come 1.0.0-rc.1.dev.3...

Ideally it should be ``1.0.0.dev.3...` as you continue snapshots on the same major/minor/patch

Per @rspieldenner comments:

I would expect a candidate producing 2.1.0-rc.2 and then a devSnapshot would return to 2.1.0-dev.#+hash

This is a breaking change

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 68.666% when pulling 77cc2a4 on fix-devSnapshot into 769e546 on master.

@rpalcolea rpalcolea merged commit f80bf78 into master Sep 13, 2019
@rpalcolea rpalcolea deleted the fix-devSnapshot branch September 13, 2019 15:58
@OdysseusLives
Copy link
Member

🎉 Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants