Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for long attribute values containing = sign #44

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

phil-janeapp
Copy link
Contributor

@phil-janeapp phil-janeapp changed the title Handle unquoted values without a regex check Fix for long attribute values containing = sign Feb 6, 2024
@elia
Copy link
Member

elia commented Feb 8, 2024

Thanks @phil-janeapp, this looks great 🙌

I was wondering if there was a way to fix the UNQUOTED_VALUE regexp so that it covers both double " and single ' quoted values.

Also it should add test coverage for single quoted ones

@phil-janeapp
Copy link
Contributor Author

@elia I added a test for single-quoted attributes. Can you clarify what you meant about the UNQUOTED_VALUE check? In looking at the code there shouldn't be an issue with different quote styles.

@elia
Copy link
Member

elia commented Feb 26, 2024

Hey @phil-janeapp, sorry for letting you wait, I ended up checking out the branch to try the code out and implemented what I meant, feel free to check it out.

Thanks for tackling this! 🙌

@elia elia merged commit a5d44b0 into nebulab:main Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format unquotted attributes adding quotes to already quoted attributes
2 participants