Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a new release now that Ruby 3.0 is out #29

Closed
rubendinho opened this issue Feb 13, 2021 · 6 comments
Closed

Cut a new release now that Ruby 3.0 is out #29

rubendinho opened this issue Feb 13, 2021 · 6 comments

Comments

@rubendinho
Copy link

rubendinho commented Feb 13, 2021

Hi -

Do you plan on releasing a version compatible with Ruby 3, now that it's the latest stable version of Ruby?

I see that the keyword argument issue was already fixed in #28.

Thanks

@Rheisen
Copy link

Rheisen commented Mar 7, 2021

Is the keyword argument issue fixed? I've been trying to get simple command to work with keyword arguments using Ruby 3.0.0, and I've been getting ArgumentErrors.

Example:

class User::CreateUser
  prepend SimpleCommand

  def initialize(create_params:)
    @create_params = create_params
  end

  def call
  end
end

That will give me an error if I tried to do: User::CreateUser.call(create_params: {first_name:"Alice"})
The error will be: ArgumentError (wrong number of arguments (given 1, expected 0; required keyword: create_params))

@rubendinho
Copy link
Author

rubendinho commented Mar 8, 2021 via email

@codedeleter
Copy link

Any chance a new gem version will be released in the future?

@dpep
Copy link

dpep commented Apr 27, 2022

@kennyadsl any chance you could cut a release to ship Ruby 3 compatibility?

@kennyadsl
Copy link
Member

I'll try to take a look and release a new gem version tomorrow.

@kennyadsl
Copy link
Member

Done 0.2.0 is out! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants