More specific version for monetize #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @huoxito thanks for your help and great find. Why did you also lock the ransack version? |
|
hey @kennyadsl I think it's seems safer locking to patch versions but I'm not sure what the guidelines are here. Let me revert that. It would be great to understand that failing spec better too, this could not be the best solution. |
huoxito
force-pushed
the
specific-monetize-ransack
branch
from
2ad2356
to
f97d973
Compare
|
@huoxito I think the issue comes from this PR in the |
It seems to provide inconsistent results with latest money gem v6.12
This reverts commit f97d973.
See https://www.rubydoc.info/gems/money/Money#allocate-instance_method Splits a given amount in parts without loosing pennies. The left-over pennies will be distributed round-robin amongst the parties. This means that parties listed first will likely receive more pennies than ones that are listed later.
|
@kennyadsl locking to monetize 1.8.0 seems the easiest way to get going for now. I created RubyMoney/monetize#118 maybe we get some help there too. |
kennyadsl
changed the title
kennyadsl
added a commit
that referenced
this pull request
Aug 27, 2018
This commit comes from @huoxito work on #15 (Thanks!) On newer versions monetize requires money 6.12 which has a rewrite of the Money#allocate method that we use in DistrubutedAmount calculator. This is the PR that is causing issues: RubyMoney/money#772 This is the issue we need to be solved before relaxing the dependency again: RubyMoney/monetize#118
kennyadsl
added a commit
that referenced
this pull request
Sep 12, 2018
This commit comes from @huoxito work on #15 (Thanks!) On newer versions monetize requires money 6.12 which has a rewrite of the Money#allocate method that we use in DistrubutedAmount calculator. This is the PR that is causing issues: RubyMoney/money#772 This is the issue we need to be solved before relaxing the dependency again: RubyMoney/monetize#118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related solidusio#2826