Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor shipping_manifest on Spree::Shipment and Spree::Carton #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] Refactor shipping_manifest on Spree::Shipment and Spree::Carton #20

wants to merge 3 commits into from

Commits on Oct 26, 2018

  1. Rename Spree::Shipment#manifest to shipping_manifest_items 

    `manifest` method returns Spree::ShippingManifest#items, this commit is
going to rename it to `shipping_manifest_items`.

I also refactored it to use the memoize shipping_manifest method.
    @DanielePalombo
    DanielePalombo committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    c3d8315 View commit details
    Browse the repository at this point in the history

  2. Rename Spree::Carton#manifest to shipping_manifest_items 

    `manifest` method returns Spree::ShippingManifest#items, this commit is
going to rename it to `shipping_manifest_items`.

I also refactored it to use the memoize shipping_manifest method.
    @DanielePalombo
    DanielePalombo committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    fdc4551 View commit details
    Browse the repository at this point in the history

  3. Rename manifest_for_order to shipping_manifest_for_order 

    This commit is going to rename the method `manifest_for_order` to
`shipping_manifest_for_order`
I also refactored it to use the memoized `shipping_manifest` method.
    @DanielePalombo
    DanielePalombo committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    e43dd87 View commit details
    Browse the repository at this point in the history