Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release as a universal wheel #31

Closed
wants to merge 1 commit into from

Conversation

adamchainz
Copy link

By releasing as a Python wheel as well as a source distribution, you can speed up end user’s installs. After merging this command, to release you just need to run python setup.py clean sdist bdist_wheel upload.

By releasing as a [Python wheel](http://pythonwheels.com/) as well as a source distribution, you can speed up end user’s installs. After merging this command, to release you just need to run `python setup.py clean sdist bdist_wheel upload`.
@coveralls
Copy link

coveralls commented Oct 14, 2016

Coverage Status

Coverage remained the same at 76.337% when pulling c3f95d8 on adamchainz:universal_wheels into 9ffbcaa on necaris:master.

@necaris
Copy link
Owner

necaris commented Oct 14, 2016

Thanks for the PR @adamchainz . My understanding is that universal wheels must support Python 2 and 3 in the same codebase -- is that not the case? If so, since this package does not currently support Python < 3.3, that would not be appropriate.

There is already an issue open for wheel builds of this package, and I hope to get to that soon. I have also just opened another for Python 2 support.

I'm going to close this since it does not add to the already-open or just-opened issues, although if we gain Python 2 support it may be useful again.

@necaris necaris closed this Oct 14, 2016
@adamchainz
Copy link
Author

Ah sorry, I didn't realise this doesn't support Python 2, we just switched to it with our upgrade to python 3.

@necaris
Copy link
Owner

necaris commented Oct 14, 2016

No worries, if I get any time to refactor it I might bring Python 2 support back in. Congrats on upgrading to Python 3!

@adamchainz
Copy link
Author

🚀 🐍 🐍 🐍

@ghickman ghickman mentioned this pull request Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants