Rewrite docker-compose.yml for following writing standards and Use env_file instead of environment

[tenshiAMD]

This will lessen the redundancy of the environment declarations and helps for easily changing the environment without changing the environments of the other containers at the same time; allowing it to be more flexible to use since environments are shared with the different containers. 👍

[neckhair]

Thanks @tenshiAMD for your PR. I already started working on this ;-). I'll have a look later.

[neckhair]

You also have to change to following line in database.yml:

password: <%= ENV['DB_ENV_MYSQL_ROOT_PASSWORD'] %>

This should now point to the changed env variable.

[neckhair]

This should not go in here. Because every time a container with this env variable is launched nginx picks that up. you can define it in the specific section of the docker-compose.yml.

[tenshiAMD]

Another way is to separate the env file that needed to separated environments to the other container, I'd just noticed the declared environment variables are redundant to others so I'd use the env file to remove the redundancy and make it more flexible if adding another environment variable.

[neckhair]

But the VIRTUAL_HOST env variable is only used in the web containers. So this specific one is actually no duplicated. The others are fine in here becuase they are used in several containers.