Skip to content

Commit

Permalink
Mention using 'pull_request_target` event (#49)
Browse files Browse the repository at this point in the history
This is significant if the PR is created by dependabot. Without this change you can't pass a secret through to the action.
  • Loading branch information
flcdrg committed Jun 2, 2021
1 parent aabf9af commit dfe6cff
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,3 +221,7 @@ files:
with:
token: ${{ secrets.PAT_FOR_AUTO_REQUEST_REVIEW }}
```

#### Dependabot compatibility

Note that with the [recent change to GitHub Actions that are created by Dependabot](https://github.blog/changelog/2021-02-19-github-actions-workflows-triggered-by-dependabot-prs-will-run-with-read-only-permissions/), the `pull_request` event will no longer give access to your secrets to this action. Instead you will need to use the `pull_request_target` event. If you do this make sure to read [Keeping your GitHub Actions and workflows secure: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) to understand the risks involved.

0 comments on commit dfe6cff

Please sign in to comment.