"Review cannot be requested from pull request author." error thrown when a default reviewer opens a PR.

[a-tokyo]

When the PR author is assigned as a default reviewer, the action fails with the error "Review cannot be requested from pull request author." .

Expected behavior:
Simply skip the reviewer addition if the reviewer is the same as the PR author.

[necojackarc]

@a-tokyo Thanks for reporting a bug!

Could you share your settings and the author name when you saw the error? I can't seem to reproduce the bug and actually, there is the logic to exclude the author from reviewers in the case you mentioned:

auto-request-review/src/index.js

Line 53 in de08bc0

const default_reviewers = fetch_default_reviewers({ config, excludes: [ author ] });

The logic does just a simple comparison, so I wonder whether or not there might be a case-sensitivity issue.

[a-tokyo]

@necojackarc Thanks for the response!

I don't have the code atm as I replaced it with another library, but I know for a fact that my username sometimes has case sensitivity issues. It's actually A-tokyo. So it might be that.

The Logic I did was to assign a-tokyo and qa-team as default reviewers. a-tokyo is in the QA team as well.

Feel free to either try it out or close the issue = )

[necojackarc]

@a-tokyo Thanks. Yeah, it sounds like an issue around case sensitivity. I believe it could work if you used exactly the same username in the settings 👍

I'm happy to leave this issue open as this sounds like a common issue for those who use any capital letters in their usernames. I hope I can find some time and compare the names in a case-insensitive way.

[necojackarc]

It turns out this isn't a bug, so I'm closing this issue in order not to confuse us but I've added a new issue #37 to make it more convenient.