Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-request-review doesn't add reviewers from github team. #55

Closed
lurbanski-equinix opened this issue Jan 10, 2022 · 8 comments
Closed
Labels
enhancement New feature or request

Comments

@lurbanski-equinix
Copy link

lurbanski-equinix commented Jan 10, 2022

Hi,
Normal configuration with list of reviewer works. Thanks a lot. It is very useful action.

I have an issue with using github team. The action doesn't add reviewers from a github team.

Logs:

with:
    token: ***
    config: .github/config/reviewers.yaml
Fetching configuration file from the source branch
Fetching changed files in the pull request
Identifying reviewers based on the changed files
A "files" key does not exist in config; returning no reviewers for changed files.
Identifying reviewers based on the author
Adding other group members to reviewers if group assignment feature is on
Group assignment feature is enabled
Randomly picking reviewers if the number of reviewers is set
Requesting review to team:my-team

Configuration:

- name: Auto request review
   uses: necojackarc/auto-request-review@91e252d75fe335f586be7e243c39e5dd88f2e153
   with:
      token: ${{ secrets.GIT_PAT }}
      config: .github/config/reviewers.yaml

reviewers.yaml

reviewers:
  per_author:
    lurbanski-equinix:
      - team:my-team

options:
  ignore_draft: false
  enable_group_assignment: true

I also tried to set "Enable auto assignment" in the team settings, but it doesn't work as well.
My GIT_PAT has full access to repo.

@necojackarc
Copy link
Owner

Hi, thank you for you bug report and sorry for the late reply! I've been struggling to find spare time, but I'll try to have a look!

@necojackarc necojackarc added the bug Something isn't working label Jan 21, 2022
@lurbanski-equinix
Copy link
Author

@necojackarc no problem.

@lurbanski-equinix
Copy link
Author

I gently remind about the issue.

@rafistrauss
Copy link

@lurbanski-equinix I just set this up for my own team, I wonder if you need the files key as well? Something like

files:
  '**':
    - team:my-team 

@lurbanski-equinix
Copy link
Author

Thanks rafistrauss. Nice workaround, but I need different reviewers depend on commit authors.

@lurbanski-equinix
Copy link
Author

Also using this configuration should be accessible.

reviewers:
  per_author:
     team:my-team:
      - team:my-team

@hbrysiewicz
Copy link
Contributor

Bump on this

@necojackarc necojackarc added enhancement New feature or request and removed bug Something isn't working labels May 4, 2023
@necojackarc
Copy link
Owner

necojackarc commented May 23, 2023

#88 has added support for the following configuration:

reviewers:
  per_author:
    team:koopa-troop:
      - mario

Many thanks to @hbrysiewicz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants