Use team keys for authors

[hbrysiewicz]

It was not initially clear in README that teams:{gh-team-name} syntax was only used for reviewers. I tried using it for the per_author keys and it (obviously) didn't work. So I wrote this in so that it would work. If the PR author is in the per_author team:{gh-team-name} collection, use the respective reviewer for assignment.

reviewers:
  per_author:
    team:koopa-troop:
      - mario

For example, this configuration would assign reviewer mario when the PR author is in github team koopa-troop.

[necojackarc]

Thanks for raising a PR! Looks good to me 👍 Clean code!
I'll update the dist and see if CI passes 🤞

[necojackarc]

I can't push commits to this branch, so I've made this PR #89 but it's still half-done.

[hbrysiewicz]

@necojackarc I pushed updates per PR comments.

[necojackarc]

Have you been able to check if it returns this in this format?
I haven't got around to but I wonder it may return a response in a data property 🤔

[hbrysiewicz]

https://docs.github.com/en/rest/teams/members?apiVersion=2022-11-28#list-team-members
It does look like it returns an array. From the documentation the schema doesn't appear to be in a data property

[necojackarc]

This is the document for the REST API wrapped in octokit, so it doesn't tell us how octokit returns its response. It may or may not have data. octokit.repos.getContent returns a response with a data property, so I suspect octokit.teams.listMembersInOrg may do the same thing, but I'm not sure yet. Need a way to play around with this API... or the official document (or reading the code...).

auto-request-review/src/github.js

Lines 45 to 50 in 4bb98f3

	const { data: response_body } = await octokit.repos.getContent({
	owner: context.repo.owner,
	repo: context.repo.repo,
	path: config_path,
	ref: context.ref,
	});

[hbrysiewicz]

Just bumping on this to see if I can help move it forward at all

[necojackarc]

@hbrysiewicz Sorry for the late reply. I didn't manage to get around to GitHub until today.

Your idea, design and implementation seem all good. I'm happy to help this PR get merged, but I can't push changes to your branch, so here's the first thing we have to do - could you run npm build to update dist? That's the current reason CI is failing.

Once you push it, we can see if all the tests are running fine.

[hbrysiewicz]

Build has been pushed

[hbrysiewicz]

@necojackarc waiting for maintainer to approve the test run

[necojackarc]

@hbrysiewicz Thanks. I need to find a way to let contributors run GitHub actions...
Perhaps, I need to use pull_request_target, not pull_request, off the top of my head.

[hbrysiewicz]

@necojackarc Just pushed up the eslint fixes if you can run again.

[necojackarc]

@hbrysiewicz Please could you back-merge the latest master to your branch so that you can run the CI workflows without approval? I believe this works by looking at the document (I've also added Node v18 to CI). #90

[hbrysiewicz]

@necojackarc All done

[necojackarc]

LGTM. Thanks for your contribution!

[necojackarc]

LGTM. Thanks for your contribution!

[hbrysiewicz]

@necojackarc it looks like context.repo.org is not working on line 121 src/github.js. Do you know where docs for this context might be or where the correct location of org is?

[necojackarc]

@hbrysiewicz Let me revert this first since this action is used in more than 400 repos, so I can't keep the latest version broken. Let's discuss it in the next PR you created.