[fix] NativeMethodsMixin measure/measureInWindow with scroll

Account for scroll offsets when calculating measurements. Fix #702 Fix #805 Close #806
necolas · Feb 12, 2018 · 399f465 · 399f465
1 parent 9ee89bc
commit 399f465
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/react-native-web/src/exports/UIManager/index.js b/packages/react-native-web/src/exports/UIManager/index.js
@@ -16,11 +16,13 @@ import setValueForStyles from '../../vendor/setValueForStyles';
 const getRect = node => {
   const height = node.offsetHeight;
   const width = node.offsetWidth;
-  let left = 0;
-  let top = 0;
+  let left = node.offsetLeft;
+  let top = node.offsetTop;
+  node = node.offsetParent;
+
   while (node && node.nodeType === 1 /* Node.ELEMENT_NODE */) {
-    left += node.offsetLeft;
-    top += node.offsetTop;
+    left += node.offsetLeft - node.scrollLeft;
+    top += node.offsetTop - node.scrollTop;
     node = node.offsetParent;
   }
   return { height, left, top, width };