[change] remove NetInfo.isConnected.getConnectionInfo()

React Native doesn't have `NetInfo.isConnected.getConnectionInfo()`. This was incorrectly added to the API while updating the main `NetInfo` API. Close #937
necolas · May 8, 2018 · 8b1e6f8 · 8b1e6f8
1 parent 02b6f3f
commit 8b1e6f8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/packages/react-native-web/src/exports/NetInfo/__tests__/index-test.js b/packages/react-native-web/src/exports/NetInfo/__tests__/index-test.js
@@ -37,6 +37,15 @@ describe('apis/NetInfo', () => {
       } catch (e) {}
     });
 
+    describe('fetch', () => {
+      test('returns a boolean', done => {
+        NetInfo.isConnected.fetch().then(isConnected => {
+          expect(isConnected).toBe(true);
+          done();
+        });
+      });
+    });
+
     describe('addEventListener', () => {
       test('throws if the provided "eventType" is not supported', () => {
         expect(() => NetInfo.isConnected.addEventListener('foo', handler)).toThrow();

diff --git a/packages/react-native-web/src/exports/NetInfo/index.js b/packages/react-native-web/src/exports/NetInfo/index.js
@@ -156,11 +156,6 @@ const NetInfo = {
     },
 
     fetch(): Promise<boolean> {
-      console.warn('`fetch` is deprecated. Use `getConnectionInfo` instead.');
-      return NetInfo.isConnected.getConnectionInfo();
-    },
-
-    getConnectionInfo(): Promise<boolean> {
       return new Promise((resolve, reject) => {
         try {
           resolve(window.navigator.onLine);

diff --git a/website/storybook/2-apis/NetInfo/NetInfoScreen.js b/website/storybook/2-apis/NetInfo/NetInfoScreen.js
@@ -107,9 +107,9 @@ const NetInfoScreen = () => (
 
     <Section title="Properties">
       <DocItem
-        description="An object with the same methods as above but the listener receives a boolean which represents the internet connectivity. Use this if you are only interested with whether the device has internet connectivity."
+        description="An object with similar methods as above but the listener receives a boolean which represents the internet connectivity. Use this if you are only interested with whether the device has internet connectivity."
         example={{
-          code: `NetInfo.isConnected.getConnectionInfo().then((isConnected) => {
+          code: `NetInfo.isConnected.fetch().then((isConnected) => {
   console.log('Connection status:', (isConnected ? 'online' : 'offline'));
 });`
         }}