Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppState should not be using functions as property names #151

Closed
ckknight opened this issue Jun 17, 2016 · 0 comments
Closed

AppState should not be using functions as property names #151

ckknight opened this issue Jun 17, 2016 · 0 comments

Comments

@ckknight
Copy link

Given the following code:

function run() {
  function handler() { /* ... */ }
  AppState.addEventListener('change', handler);
  return function () {
    AppState.removeEventListener('change', handler);
  }
}

Because AppState is managing its listeners in an object, the handler above will use its .toString() value as the key of listeners, which is equivalent between function calls.

One solution would be to use a Map, thus removing the implicit [[ToString]].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant