[change] Remove default ES Module export #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the default export that was provided for compatibility with legacy
imports of React Native CommonJS modules. These patterns is no longer
supported:
```
import ReactNative from 'react-native';
const ReactNative = require('react-native');
```
Fix #1258
kmagiera
pushed a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Jun 1, 2019
# Why Default import was removed from react-native-web. necolas/react-native-web#1277 The use of module.exports and import/export breaks tree-shaking in with babel-preset-expo. Related: #617 Fixes: expo/expo#4339 # How * Moved the shims to `Gestures(.web).js` * Moved all modules out of main re-export file. (optional)
|
Hi @necolas I'm not sure to understand why the default has been removed. See my issue for more information : #1366 Is there any other way to make it work without change the export ? |
|
@joan-saum Please see the related issue: #1258 and facebook/metro#362 |
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
# Why Default import was removed from react-native-web. necolas/react-native-web#1277 The use of module.exports and import/export breaks tree-shaking in with babel-preset-expo. Related: software-mansion#617 Fixes: expo/expo#4339 # How * Moved the shims to `Gestures(.web).js` * Moved all modules out of main re-export file. (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default export that was provided for compatibility with legacy
imports of React Native CommonJS modules. These patterns is no longer
supported:
Fix #1258