Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onScroll(Begin|End)Drag Events #1305

Closed

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Mar 26, 2019

* Added `onScrollBeginDrag`
* Added `onScrollEndDrag`
@EvanBacon
Copy link
Contributor Author

Upon further review it seems that perhaps the onScrollEndDrag is implemented closer to onMomentumScrollEnd since a debounce is involved.
I can't find a very consistent way to observe if Momentum is enabled. Perhaps we should add that before implementing onMomentumScrollBegin, onMomentumScrollEnd.

@EvanBacon
Copy link
Contributor Author

hmm #1091 🙁 perhaps that PR should be fixed instead. I need this and a few other features to get added to ScrollView to fix a couple of complex interactions.

@necolas
Copy link
Owner

necolas commented Mar 26, 2019

Yeah this doesn't look quite right. I think these scroll events are going to be more complicated to implement as they will need to be aware of whether a touch is active in order to determine whether scrolling is momentum-based or not. No idea what the situation for trackpads is.

Ref #1021

@necolas necolas added this to the Flare milestone Mar 26, 2019
@EvanBacon
Copy link
Contributor Author

Perhaps we could create new props like onScrollBegin, onScrollEnd. It would be really helpful to access these values. The alternative of using onScroll with an animated value is a huge bottle neck on performance. Of course I would much rather have this done correctly, but the particular invocation this is currently surfacing is pretty valuable.

ex: onScroll & comparing every frame

@evie9z
Copy link

evie9z commented Mar 14, 2020

Hi, I'm working on a project that really needs this feature. May I ask any updates on this PR yet?

@shljessie
Copy link

shljessie commented Jul 22, 2020

How is this going ?
@EvanBacon @necolas

@KingAmo
Copy link
Contributor

KingAmo commented Aug 31, 2020

any update on this ? i just want do something when scroll begin

@lucaashrq
Copy link

Any update?

@EvanBacon
Copy link
Contributor Author

I don't have time to investigate this further, please see @necolas's comment for reasons this cannot be merged in its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants