Include support to react v15.4 #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagofelix
changed the title
|
Dup of #255 |
|
Thanks @MoOx for pointing out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch solves the following problem
Breaking changes with react v15.4.
The package react-dom isn't bundled with react anymore therefore its modules can't be accessed via
require('react/lib/*')Test plan
Previously react-native-web apps wouldn't work when running along side react v15.4+ version.
Test plan would be simply trying to run any of the existing example/demo apps and expect it not to break.
This pull request
I am not sure if these changes need to be informed somewhere in the documentation, please let me know if something is missing.
Thanks