Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#534 anritsu sg #547

Merged
merged 8 commits into from
Jun 24, 2024
Merged

#534 anritsu sg #547

merged 8 commits into from
Jun 24, 2024

Conversation

TatsumiISHIKAWA
Copy link
Contributor

@TatsumiISHIKAWA TatsumiISHIKAWA commented Jun 19, 2024

Checks

  • Debugging completed
  • Please debug me

Related Issue

This PR closes #534

@TatsumiISHIKAWA TatsumiISHIKAWA added the enhancement New feature or request label Jun 19, 2024
@TatsumiISHIKAWA TatsumiISHIKAWA added this to the Release v0.26.0 milestone Jun 19, 2024
@TatsumiISHIKAWA TatsumiISHIKAWA self-assigned this Jun 19, 2024
@TatsumiISHIKAWA TatsumiISHIKAWA changed the title #534 anritsu sg [WIP] #534 anritsu sg Jun 19, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 47.22222% with 38 lines in your changes missing coverage. Please review.

Project coverage is 84.21%. Comparing base (da918a1) to head (b027a45).
Report is 48 commits behind head on main.

Current head b027a45 differs from pull request most recent head 3840831

Please upload reports for the commit 3840831 to get more accurate results.

Files Patch % Lines
neclib/devices/signal_generator/mg3692c.py 37.28% 37 Missing ⚠️
neclib/devices/signal_generator/e8257d.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   84.48%   84.21%   -0.27%     
==========================================
  Files         201      206       +5     
  Lines        8325     8441     +116     
==========================================
+ Hits         7033     7109      +76     
- Misses       1292     1332      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TatsumiISHIKAWA TatsumiISHIKAWA changed the title [WIP] #534 anritsu sg #534 anritsu sg Jun 22, 2024
@yamatomatsuzuki yamatomatsuzuki added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 5a6946c Jun 24, 2024
4 checks passed
@yamatomatsuzuki yamatomatsuzuki deleted the #534-Anritsu_sg branch June 24, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Signal Generator : Anritsu MG3692C
2 participants