Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception reporter bug #160

Merged
merged 4 commits into from
May 5, 2020
Merged

Exception reporter bug #160

merged 4 commits into from
May 5, 2020

Conversation

thumbnail
Copy link
Member

Brief

discovered in #154, in some cases an exception occur, which are passed into reporter, without filenames. This is expected as the exception sometimes escapes the context where the filename is available (especially in process-in-parallel!).

This triggers a spec-error which hides the initial exception, as shown in the failing CI here: https://circleci.com/gh/nedap/formatting-stack/1818

QA plan

Fixed CI after 3a9c4a7 (revert to see breakage)

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

@thumbnail thumbnail requested a review from a team May 5, 2020 15:03
src/formatting_stack/reporters/impl.clj Outdated Show resolved Hide resolved
test/functional/formatting_stack/core.clj Outdated Show resolved Hide resolved
:processors []
:reporter (recording-recorder x)
:in-background? false)
(is (match? [{:source :formatting-stack/process!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u.t/expect?

It would look like overkill atm, but one never knows how tests could grow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried u.t/expect, but it's a bit hard to use in this case, as it uses meta=. Kept the test as is, can reevaluate when we expand it.

Copy link

@lennartbuit lennartbuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intimately familiar with the code, but seems good to me

@thumbnail thumbnail merged commit 36f6b10 into master May 5, 2020
@thumbnail thumbnail mentioned this pull request May 5, 2020
7 tasks
@thumbnail thumbnail deleted the exception-reporter-bug branch May 6, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants