-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception reporter bug #160
Conversation
:processors [] | ||
:reporter (recording-recorder x) | ||
:in-background? false) | ||
(is (match? [{:source :formatting-stack/process! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u.t/expect
?
It would look like overkill atm, but one never knows how tests could grow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried u.t/expect
, but it's a bit hard to use in this case, as it uses meta=
. Kept the test as is, can reevaluate when we expand it.
but can be nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not intimately familiar with the code, but seems good to me
Brief
discovered in #154, in some cases an exception occur, which are passed into reporter, without filenames. This is expected as the exception sometimes escapes the context where the filename is available (especially in
process-in-parallel!
).This triggers a spec-error which hides the initial exception, as shown in the failing CI here: https://circleci.com/gh/nedap/formatting-stack/1818
QA plan
Fixed CI after
3a9c4a7
(revert to see breakage)Author checklist
Reviewer checklist