Skip to content

Commit

Permalink
Relax the PR checklists
Browse files Browse the repository at this point in the history
  • Loading branch information
vemv committed Aug 14, 2019
1 parent a663120 commit d05b696
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions .github/pull_request_template.md
Expand Up @@ -13,8 +13,9 @@
* [ ] I have QAed the functionality
* [ ] The PR has a reasonably reviewable size and a meaningful commit history
* [ ] I have run the [branch formatter](https://github.com/nedap/formatting-stack/blob/332a419034ab46fad526a5592f4257353bd695b6/src/formatting_stack/branch_formatter.clj) and observed no new/significative warnings
* [ ] I have self-reviewed the PR prior to assignment, and its build passes
* Specifically, I have code-reviewed iteratively the PR considering the following aspects in isolation:
* [ ] The build passes
* [ ] I have self-reviewed the PR prior to assignment
* Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
* [ ] Correctness
* [ ] Robustness (red paths, failure handling etc)
* [ ] Modular design
Expand All @@ -30,8 +31,9 @@

* [ ] I have checked out this branch and reviewed it locally, running it
* [ ] I have QAed the functionality
* I have code-reviewed iteratively the PR considering the following aspects in isolation:
* [ ] Business-facing correctness
* [ ] I have reviewed the PR
* Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
* [ ] Correctness
* [ ] Robustness (red paths, failure handling etc)
* [ ] Modular design
* [ ] Test coverage
Expand Down

0 comments on commit d05b696

Please sign in to comment.