-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize previous cog output handling #30
Conversation
FWIW, all tests pass:
|
Thanks for the pull request! I've never used on cog on such large files so haven't suffered the performance problem. Looking at your changes, I'm not sure we need to deal with the input and output files differently. I think the speed problems are all due to how |
Hey Ned, thanks for the quick reply! You're right - the speed is the same only with the change to Thanks,
|
29edea6
to
03328a1
Compare
Storing the previous cog output present in the file as a list instead of a string
03328a1
to
2c24a7f
Compare
Hmm, that is odd, I can't think why a stringIO for reading would have an effect at all, but I like the simplicity of the latest code, and it gets us the full benefit! |
Exactly! Thanks for merging :)) |
Using StringIO for input and output files in all casesStoring the previous code present in the file as a list instead of a string
Fixes #29