Try some changes to see whether HTML report performance gets better #1778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: I couldn't improve HTML report performance, only submitting a PR to record investigations somewhere.
HTML reports are lagging noticeably for sorting and page load with long lists of functions.
I've done my best to investigate but couldn't find anything that actually improved the situation. The changes in this PR seemed like good ideas:
getCellValue
to the code that actually runs (maybe the deleted code is necessary for other browsers?).I can't detect any improvements to performance from these.
But I'm also fairly sure now that we aren't doing something too obviously wrong, like quadratic loops or firing expensive events too frequently. It seems to be something related to DOM and JS performance, above my competence level.
The Chrome developer tools sometimes pops up
[Violation] Forced reflow while executing JavaScript took XXms
, but I couldn't get rid of the reflow by reordering attribute accesses.Maybe we can record sort order and use it instead of sorting every time, but even that isn't a clear win AFAICS.